London | 26-SDC-Mar | Beko | Sprint 1 | Individual shell tools exercises by Abubakar-Meigag · Pull Request #352 · CodeYourFuture/Module-Tools

Abubakar-Meigag · 2026-03-11T16:59:20Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

complete individual shell tools exercises

Questions

no questions, thanks!

SlideGauge

There a couple of files which do not have empty line in the end of the file (like wc/script-02.sh). Could you add them please

SlideGauge · 2026-03-31T21:31:49Z


 set -euo pipefail

+awk '{print NF}' scores-table.txt


What does NF mean in this context and what will this line output?

NF counts the number of fields in each row, so it was outputting the word count per line rather than the names

I've updated the command to use $1 instead, which prints the value of the first field.

SlideGauge · 2026-03-31T21:32:38Z


 set -euo pipefail

+awk '/London/ {print $1, $4}' scores-table.txt


What happens when we meet lines with different number of scores?

$4 is hardcoded so it won't work for players with different number of scores
i should use $NF instead which always points to the last field.

SlideGauge · 2026-03-31T21:36:35Z

 set -euo pipefail

+
+grep -v "Hello" dialogue.txt


Will it find lines like "hello" (lowercase)?

No, it won't catch lowercase 'hello' because grep is case-sensitive by default.

i've added the -i flag to make it case-insensitive

SlideGauge · 2026-03-31T21:40:49Z

 # TODO: Write a command to list the files and folders in this directory.
 # The output should be a list of names including child-directory, script-01.sh, script-02.sh, and more.
+
+ls ../ls


README file says
"You should write all of your scripts assuming they're running inside the directory they're saved in."
Whilst this line works, it does redundant operation with the path, could you simplify it?

Since the script runs in its own directory

i can just use ls with no path.

updated

SlideGauge · 2026-03-31T21:40:56Z

 # TODO: Write a command which lists all of the files in the directory named child-directory.
 # The output should be a list of names: helper-1.txt, helper-2.txt, helper-3.txt.
+
+ls ../ls/child-directory


README file says
"You should write all of your scripts assuming they're running inside the directory they're saved in."
Whilst this line works, it does redundant operation with the path, could you simplify it?

SlideGauge · 2026-03-31T21:41:15Z


 echo "First exercise (sorted newest to oldest):"
-
+ls -t ../ls/child-directory


README file says
"You should write all of your scripts assuming they're running inside the directory they're saved in."
Whilst this line works, it does redundant operation with the path, could you simplify it?

SlideGauge · 2026-03-31T21:42:24Z

 # The output should be a list of names including: child-directory, script-01.sh, helper-1.txt (and more).
 # The formatting of the output doesn't matter.
+
+ls ../ls ../ls/child-directory 


Also, will it output directories contents recursively?

SlideGauge · 2026-03-31T21:44:17Z


 set -euo pipefail

+grep -l "Doctor:" *.txt


Will it output only lines of the Doctor or can it potentially output lines which contain "Doctor:" somewhere in the middle?

It can match 'Doctor:' anywhere in the line

so I've added ^ to anchor it to the start.

SlideGauge · 2026-03-31T21:46:48Z


 set -euo pipefail

+awk '/London/ {print $1, $4}' scores-table.txt


What will happen if some of the player's have name "London" but the city is not London?

SlideGauge · 2026-03-31T21:49:54Z


 set -euo pipefail

+awk '{for (i=3; i<=NF; i++) sum[$1] += $i} END {for (name in sum) print name, sum[name]}' scores-table.txt


Does for (name in sum) guarantee the order of traversal?

actually no, for (name in sum) doesn't guarantee order
because awk arrays are associative so traversal is arbitrary

i've fixed it by tracking the names in a separate ordered array

SlideGauge · 2026-03-31T21:51:44Z

Wrote my notes, could you fulfil them please?

Abubakar-Meigag · 2026-06-07T22:24:51Z

Hi @SlideGauge thanks for the review, I've completed all the changes for the code review and feedback

Thanks!

complete individual shell tools exercises

5ea068a

This comment has been minimized.

Sign in to view

Abubakar-Meigag added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026

Abubakar-Meigag added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026

Abubakar-Meigag added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Tools The name of the module. labels Mar 11, 2026

SlideGauge reviewed Mar 31, 2026

View reviewed changes

SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 31, 2026

update for code review feedback on awk, grep, and ls exercises

43b1572

Abubakar-Meigag added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 7, 2026


		set -euo pipefail

		awk '/London/ {print $1, $4}' scores-table.txt


		echo "First exercise (sorted newest to oldest):"

		ls -t ../ls/child-directory


		set -euo pipefail

		awk '{for (i=3; i<=NF; i++) sum[$1] += $i} END {for (name in sum) print name, sum[name]}' scores-table.txt

Uh oh!

Conversation

Abubakar-Meigag commented Mar 11, 2026

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SlideGauge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SlideGauge commented Mar 31, 2026

Uh oh!

Abubakar-Meigag commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants